PulseAudio: Use default sink at multiple sink environment #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please confirm the CI. |
itchyny
reviewed
Mar 23, 2020
volume_linux.go
Outdated
| } | ||
|
|
||
| var volumePattern = regexp.MustCompile(`\d+%`) | ||
|
|
||
| func parseVolume(out string) (int, error) { | ||
| lines := strings.Split(out, "\n") | ||
| pa_default_sink_hooked := false |
There was a problem hiding this comment.
I would prefer using camelCase in Golang.
Library Protocol Version: 32 Server Protocol Version: 32 Is Local: no Client Index: 248 Tile Size: 65472 User Name: hikaru Host Name: hikaru-thinkpad Server Name: pulseaudio Server Version: 11.1 Default Sample Specification: s16le 2ch 44100Hz Default Channel Map: front-left,front-right Default Sink: MySink Default Source: alsa_output.pci-0000_00_1f.3.analog-stereo.monitor Cookie: 6325:d303
|
Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the original code, A PulseAudio command forced to use sink 0 for controlling/fetching volume.
The following changes allow using default sink at multiple audio sink environments. (mostly user selected on their gui/ in the case of only one sink available, pa will use it as default sink )
pactl set-sink*commands instead of sink 0.pactl infoto fetch default sink.